Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: youtube ads after upgrade (2.81.7) #1959

Closed
3 tasks done
daniandtheweb opened this issue Oct 10, 2022 · 6 comments
Closed
3 tasks done

Bug: youtube ads after upgrade (2.81.7) #1959

daniandtheweb opened this issue Oct 10, 2022 · 6 comments

Comments

@daniandtheweb
Copy link

daniandtheweb commented Oct 10, 2022

Type

Cosmetic

Bug description

After upgrading from 2.81.2 to version 2.81.7 youtube started showing some ads in the videos

Steps to reproduce

Install 2.81.7 youtube patches coming from 2.81.2.

Relevant log output

No logs

Screenshots or videos

Solution

No response

Additional context

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.

  • I have written a short but informative title.

  • I filled out all of the requested information in this issue properly.

@Enivex
Copy link

Enivex commented Oct 10, 2022

I suspect the issue is that the option was inverted without changing the text

a32af95

Try turning the toggle off instead of on.

Edit: Off, so that it says "video ads are shown" underneath. At least I haven't seen an ad yet.

@oSumAtrIX
Copy link
Member

@Enivex That might be it. In that case, the commit will be reverted.

@daniandtheweb
Copy link
Author

I did it and also cleared the app data.
There are just a few ads showing, not even close to the app without patches, but they are still there.

@ashishkotnala29
Copy link

Can confirm this issue and yes, turning the toggle OFF actually removed the Ads.

@oSumAtrIX
Copy link
Member

Fixed in commit e353ed0.

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.169.1-dev.3](ReVanced/revanced-patches@v2.169.1-dev.2...v2.169.1-dev.3) (2023-04-23)

### Bug Fixes

* **youtube/hide-video-action-buttons:** fix hide action buttons not working for some users ([ReVanced#1959](ReVanced/revanced-patches#1959)) ([3ff1489](ReVanced/revanced-patches@3ff1489))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.170.0](ReVanced/revanced-patches@v2.169.0...v2.170.0) (2023-04-24)

### Bug Fixes

* **enable-android-debugging:** don't include by default ([b2856f7](ReVanced/revanced-patches@b8273b9))
* **twitch/block-embedded-ads:** correct spelling mistake ([ReVanced#1962](ReVanced/revanced-patches#1962)) ([6138c2a](ReVanced/revanced-patches@3e3540b))
* **youtube/hide-video-action-buttons:** fix hide action buttons not working for some users ([ReVanced#1959](ReVanced/revanced-patches#1959)) ([3ab5842](ReVanced/revanced-patches@1f8d30a))
* **youtube/sponsorblock:** correct spelling mistake ([ReVanced#1941](ReVanced/revanced-patches#1941)) ([d9d0fe7](ReVanced/revanced-patches@ddf22d9))
* **youtube/sponsorblock:** use lowercase letters for URL string ([ReVanced#1942](ReVanced/revanced-patches#1942)) ([b58842a](ReVanced/revanced-patches@798bf17))
* **youtube/tablet-mini-player:** throw if fingerprint fails to resolve ([642eef3](ReVanced/revanced-patches@e82362f))

### Features

* **youtube/wide-searchbar:** rename patch ([bb5885e](ReVanced/revanced-patches@eba9929))
* **youtube:** bump compatibility to `18.15.40` ([ad82fcd](ReVanced/revanced-patches@ea2ad3a))
* **youtube:** constrain patches to `18.15.40` ([c0c10de](ReVanced/revanced-patches@7301402))
* **youtube:** remove non working patch `hide-my-mix` ([6ae0f0b](ReVanced/revanced-patches@2e6356b))
* **youtube:** support version `18.15.40` ([c3614ab](ReVanced/revanced-patches@9fcdc6d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@Enivex @oSumAtrIX @ashishkotnala29 @daniandtheweb and others