Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hide-video-buttons: incorrect buttons are being hidden (Share/Create, clip and thanks) #1975

Closed
3 tasks done
philklc opened this issue Oct 8, 2022 · 2 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@philklc
Copy link

philklc commented Oct 8, 2022

Type

Cosmetic

Bug description

Incorrect buttons are being hidden with the "Hide share button" and "Hide create, clip and thanks button" settings.

Steps to reproduce

YouTube version 17.36.37, patch version 2.81.0
In the new Hide action buttons settings, leave all options disabled. View a video and observe the buttons:
Normal video: Like, Dislike, Share, Create, Download, Save
Live video: Like, Dislike, Live chat, Share, Report, Save

Enable only the "Hide share button" setting, observe the buttons in a video:
Normal video: Like, Dislike, Download, Save (issue: Create button is also hidden)
Live video: Like, Dislike, Save (issue: Live chat, Report buttons are also hidden)

Enable only the "Hide create, clip and thanks button" setting, observe the buttons in a video:
Normal video: Like, Dislike, Share, Download, Save (correct)
Live video: Like, Dislike, Live chat, Save (issue: Share and Report buttons are hidden when they should not be)

Relevant log output

n/a

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@philklc philklc added the Bug report Something isn't working label Oct 8, 2022
@SodaWithoutSparkles

This comment was marked as spam.

@LisoUseInAIKyrios
Copy link
Contributor

Fixed in latest release (the option to selectively hide the share button was removed)

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.170.1-dev.1](ReVanced/revanced-patches@v2.170.0...v2.170.1-dev.1) (2023-04-25)

### Bug Fixes

* **youtube/spoof-signature-verification:** additional fixes for subtitle window positions ([ReVanced#1975](ReVanced/revanced-patches#1975)) ([08584e6](ReVanced/revanced-patches@11fcc18))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.171.0](ReVanced/revanced-patches@v2.170.0...v2.171.0) (2023-04-27)

### Bug Fixes

* **enable-android-debugging:** make option `debuggable` false by default ([e717e26](ReVanced/revanced-patches@7864869))
* **youtube/minimized-playback:** disable minimized playback for shorts ([ReVanced#1990](ReVanced/revanced-patches#1990)) ([b91d18d](ReVanced/revanced-patches@bd69f96))
* **youtube/spoof-signature-verification:** additional fixes for subtitle window positions ([ReVanced#1975](ReVanced/revanced-patches#1975)) ([08584e6](ReVanced/revanced-patches@11fcc18))

### Features

* **id-austria:** remove compatibility version constraint ([ReVanced#1952](ReVanced/revanced-patches#1952)) ([94ffd5a](ReVanced/revanced-patches@e1fe115))
* **youtube/sponsorblock:** automatically hide skip button ([ReVanced#1956](ReVanced/revanced-patches#1956)) ([c3c8ae6](ReVanced/revanced-patches@310516a))
* **youtube:** `hide-player-overlay` patch ([ReVanced#1965](ReVanced/revanced-patches#1965)) ([d233d96](ReVanced/revanced-patches@8c79cdb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants