Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: enabling share button enables all other buttons #1998

Closed
3 tasks done
lewdpatriot opened this issue Oct 3, 2022 · 2 comments
Closed
3 tasks done

bug: enabling share button enables all other buttons #1998

lewdpatriot opened this issue Oct 3, 2022 · 2 comments
Labels
Bug report Something isn't working

Comments

@lewdpatriot
Copy link

lewdpatriot commented Oct 3, 2022 •
edited
Loading

Type

Cosmetic

Bug description

Enabling share button also enables other buttons that are disabled ( clip, create, thanks)

Steps to reproduce

Step 1: enable "hide create, clip and thanks button" and also "hide share button". -works as expected.
Step 2: disable "hide share button" -every button appears.

Relevant log output

NA

Screenshots or videos

Step 1
IMG_20221003_184042
IMG_20221003_184004
Step 2
IMG_20221003_190017
IMG_20221003_184129

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@lewdpatriot lewdpatriot added the Bug report Something isn't working label Oct 3, 2022
@oSumAtrIX
Copy link
Member

Record_2022-10-03-15-37-42.mp4

@lewdpatriot
Copy link
Author

Record_2022-10-03-15-37-42.mp4

Ok, I patched it again and it's working now, maybe it didn't patch properly earlier. Thanks

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.172.0-dev.8 [skip ci]
b0a5c8c 
# [2.172.0-dev.8](ReVanced/revanced-patches@v2.172.0-dev.7...v2.172.0-dev.8) (2023-05-01)

### Bug Fixes

* **change-package-name:** use `null` as default value for option `packageName` ([ReVanced#1998](ReVanced/revanced-patches#1998)) ([8128e6b](ReVanced/revanced-patches@b58ff28))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.172.0 [skip ci]
d409c0b 
# [2.172.0](ReVanced/revanced-patches@v2.171.0...v2.172.0) (2023-05-01)

### Bug Fixes

* **change-package-name:** use `null` as default value for option `packageName` ([ReVanced#1998](ReVanced/revanced-patches#1998)) ([8128e6b](ReVanced/revanced-patches@b58ff28))
* **youtube/minimized-playback:** fix background play of kids videos ([ReVanced#2016](ReVanced/revanced-patches#2016)) ([89b1484](ReVanced/revanced-patches@36617f2))
* **youtube/return-youtube-dislike:** support older UI layouts ([ReVanced#2031](ReVanced/revanced-patches#2031)) ([c82ccb5](ReVanced/revanced-patches@59978b6))
* **youtube/spoof-app-version:** adjust available app targets ([ReVanced#2030](ReVanced/revanced-patches#2030)) ([a16cb0d](ReVanced/revanced-patches@1647a2e))

### Features

* **youtube/general-ads:** hide multiple audio track button on video player overlay ([ReVanced#2021](ReVanced/revanced-patches#2021)) ([8d7f305](ReVanced/revanced-patches@a768ca9))
* **youtube/hide-get-premium:** hide get premium advertisements under video player ([ReVanced#2020](ReVanced/revanced-patches#2020)) ([05904a2](ReVanced/revanced-patches@98d6b87))
* **youtube/hide-player-overlay:** exclude by default ([1c6fb94](ReVanced/revanced-patches@a9168aa))
* **youtube/spoof-app-version:** user selectable version to spoof ([ReVanced#2013](ReVanced/revanced-patches#2013)) ([fd66417](ReVanced/revanced-patches@f04a341))
* **youtube/spoof-signature-verification:** list known spoofing side effects in revanced settings ([ReVanced#2011](ReVanced/revanced-patches#2011)) ([dc6e9b2](ReVanced/revanced-patches@617169a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oSumAtrIX @lewdpatriot