Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: History button disappears when "Remove general ads" is enabled #2013

Closed
3 tasks done
Zazazasu opened this issue Oct 1, 2022 · 9 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@Zazazasu
Copy link

Zazazasu commented Oct 1, 2022

Type

Error at runtime

Bug description

The area above history that lets you tap it and open your full history disappears when hiding of general ads is enabled.

Steps to reproduce

  1. Enable Remove general ads

Relevant log output

NA

Screenshots or videos

No response

Solution

No response

Additional context

Version 17.36.37 MicroG installed using manager

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Zazazasu Zazazasu added the Bug report Something isn't working label Oct 1, 2022
@arandomhooman
Copy link

I second this

@johnconner122
Copy link
Contributor

try latest patches, I don't see that bug anymore.

@arandomhooman
Copy link

@johnconner122 how do I do that? The manager has not been updated, how do I apply patches without manager?

@Ushie
Copy link
Member

Ushie commented Oct 4, 2022

@johnconner122 how do I do that? The manager has not been updated, how do I apply patches without manager?

The manager should automatically start using latest patches

@arandomhooman
Copy link

@Ushie even if it was not updated? So I just repatch?

@Ushie
Copy link
Member

Ushie commented Oct 4, 2022

@Ushie even if it was not updated? So I just repatch?

Yep, I believe patches are only cached for 6 hours so, maybe try clearing Manager's cache/data before testing

@johnconner122
Copy link
Contributor

Follow the official documentation to patch Youtube manually:
https://github.com/revanced/revanced-documentation

@arandomhooman
Copy link

@johnconner122 is what ushie saying t correct too?

@johnconner122
Copy link
Contributor

@johnconner122 is what ushie saying t correct too?

I don't know, I don't use revanced manager.

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.172.0-dev.1](ReVanced/revanced-patches@v2.171.0...v2.172.0-dev.1) (2023-04-28)

### Features

* **youtube/spoof-app-version:** user selectable version to spoof ([ReVanced#2013](ReVanced/revanced-patches#2013)) ([fd66417](ReVanced/revanced-patches@f04a341))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.172.0](ReVanced/revanced-patches@v2.171.0...v2.172.0) (2023-05-01)

### Bug Fixes

* **change-package-name:** use `null` as default value for option `packageName` ([ReVanced#1998](ReVanced/revanced-patches#1998)) ([8128e6b](ReVanced/revanced-patches@b58ff28))
* **youtube/minimized-playback:** fix background play of kids videos ([ReVanced#2016](ReVanced/revanced-patches#2016)) ([89b1484](ReVanced/revanced-patches@36617f2))
* **youtube/return-youtube-dislike:** support older UI layouts ([ReVanced#2031](ReVanced/revanced-patches#2031)) ([c82ccb5](ReVanced/revanced-patches@59978b6))
* **youtube/spoof-app-version:** adjust available app targets ([ReVanced#2030](ReVanced/revanced-patches#2030)) ([a16cb0d](ReVanced/revanced-patches@1647a2e))

### Features

* **youtube/general-ads:** hide multiple audio track button on video player overlay ([ReVanced#2021](ReVanced/revanced-patches#2021)) ([8d7f305](ReVanced/revanced-patches@a768ca9))
* **youtube/hide-get-premium:** hide get premium advertisements under video player ([ReVanced#2020](ReVanced/revanced-patches#2020)) ([05904a2](ReVanced/revanced-patches@98d6b87))
* **youtube/hide-player-overlay:** exclude by default ([1c6fb94](ReVanced/revanced-patches@a9168aa))
* **youtube/spoof-app-version:** user selectable version to spoof ([ReVanced#2013](ReVanced/revanced-patches#2013)) ([fd66417](ReVanced/revanced-patches@f04a341))
* **youtube/spoof-signature-verification:** list known spoofing side effects in revanced settings ([ReVanced#2011](ReVanced/revanced-patches#2011)) ([dc6e9b2](ReVanced/revanced-patches@617169a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants