Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: (youtube/hide-layout-components) hide "notify me" button not working #266

Closed
3 tasks done
n1cKz1 opened this issue Oct 5, 2023 · 4 comments · Fixed by ReVanced/revanced-patches-template#3087
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@n1cKz1
Copy link

n1cKz1 commented Oct 5, 2023

Bug description

Notify me button still shows up on feed as seen on my screenshot below.
Screenshot_2023-10-05-05-24-51-592_app revanced android youtube

Error logs

home_video_with_context.eml|23530c03eec5259c|CellType|video_with_context_slots.eml|ce9b7565c3e38243|ContainerType|set_reminder_button.eml|f7b07b620dfa46c3|

Solution

No response

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@n1cKz1 n1cKz1 added the Bug report Something isn't working label Oct 5, 2023
@johnconner122
Copy link
Contributor

Show full log to check if it was filtered or not.

@n1cKz1
Copy link
Author

n1cKz1 commented Oct 5, 2023

It wasn't. The only thing shown as filtered in the logs was cell_divider.eml which iirc is the grey separator. I can show full logs later if needed

@oSumAtrIX
Copy link
Member

This may be because the home feed is whitelisted.

@johnconner122
Copy link
Contributor

This may be because the home feed is whitelisted.

In that case, just check for matched group before exceptions.

@oSumAtrIX oSumAtrIX linked a pull request Oct 6, 2023 that will close this issue
1 task
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants