Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YT Music): Seamless Switch audio-video/video-audio #386

Closed
3 tasks done
YashjitPal opened this issue Aug 30, 2023 · 5 comments
Closed
3 tasks done

feat(YT Music): Seamless Switch audio-video/video-audio #386

YashjitPal opened this issue Aug 30, 2023 · 5 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@YashjitPal
Copy link

Application

Youtube Music/ YT Music

Issue

I can't change audio to video or video to audio in the mini player as it shows its a premium feature.

Patch

Screenshot_2023-08-30-19-31-01-01_261cc69e159889934ed6f60143ee2161
Screenshot_2023-08-30-19-31-50-28_261cc69e159889934ed6f60143ee2161
Whenever I try to change any song's video to audio or audio to video, it shows that the feature is called "Seamless Switch between audio and video" and it's available only in premium. So I would like to patch this.

Motivation

YouTube music is left incomplete in being totally premium without the feature. And it is also very useful as sometimes we dont have enough data to run the video and to reach the song version of the same song at the same time lapse. So overall this feature is very useful to be patched.

If you feel that there's something incomplete in this section, then please kindly explain me what I actually have to write in this portion.

Thank You.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@YashjitPal YashjitPal added the Feature request Requesting a new feature that's not implemented yet label Aug 30, 2023
@DopeDepot
Copy link

Nah bro working fine for me on version 6.16.52

@YashjitPal
Copy link
Author

Nah bro working fine for me on version 6.16.52

But that ain't working in that way I'm telling. For eg the song "Anti-Hero" has a music video. So if I play the song, there's nothing in the video section. So we can just turn the video to audio if we play a video and the audio ain't the song. It's just the thumbnail of that yt video.

@DopeDepot
Copy link

You have to search "Anti Hero video" through search.. else it says video not available. Videos songs are separate from audio only songs that's why it doesn't switch and even if it switches nothing's gonna play.

@YashjitPal
Copy link
Author

You have to search "Anti Hero video" through search.. else it says video not available. Videos songs are separate from audio only songs that's why it doesn't switch and even if it switches nothing's gonna play.

But when I had premium a few weeks ago for trial, I can just easily change from the anti hero or any other song to the music video from audio file to video file.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
@oSumAtrIX
Copy link
Member

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long
  • Low priority
  • Maintainers un-interested
  • Too complex to realize

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants