-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube): YouTube A/B testing might make RYD not work again #390
Comments
This comment was marked as spam.
This comment was marked as spam.
There is a rare chance the dislikes will not appear and a toast is not shown if the API call starts late but then completes just under the time limit. The UI will give up and not add the dislikes, but the API call completes and no toast is shown. To determine if this is the case, scroll the UI down so the likes is not visible, then scroll back up again. If the dislikes are now visible, then this was the case. If the dislikes are still missing, then it's an A/B test. This situation is unlikely and definitely won't happen all the time, but I'm listing just in case someone sees dislikes sometimes but not all the time. |
I scrolled down and back up again, and the dislikes are still missing. I also confirmed that the API call should be executed. I saw the RYD api DNS resolution in my Pi-hole, but i don't know the results. I repeated the steps on more than 5 videos. None have dislikes showed. |
This comment was marked as spam.
This comment was marked as spam.
A temporary fix is to spoof to an older app version. If you still want the latest UI, you can add a custom spoof target using the instructions here. As for fixing the issue, either some temporary logging could be added and an affected user can collect their logs and maybe it can be fixed (without the dev being able to reproduce). Or possibly this will have to wait until someone with software skills is affected and they can fix and verify it locally. |
I have some software skills and am able to collect logs as required. How can I collect the logs required? |
Using ADB and also using the debugging patch for YouTube |
Logging will need to be added for RYD (either a one off build, or temporarily added to the dev release). Because currently RYD doesn't log the litho components it encounters. It needs logging added here |
Equipping RYD with logging sounds good to me besides this issue and should be introduced via a merge of dev to main. |
@SodaWithoutSparkles you can patch and install the latest dev release, enable revanced debugging, collect the logs using adb, and then search the logs for ReturnYouTubeDislikePatch. The strings of interested will be listed with |
I think this information may helpful for you @LisoUseInAIKyrios He said that Like/Dislike Count updated in Real Time |
The problem fixed itself now. I haven't updated YT ReVanced since posting. I wonder why the RYD patch havent get bumped to support 18.37.36 |
Because 18.37.36 RYD has issues with Shorts. There is an open PR to fix the issue and add 18.37.36, and that should be merged before the next main release. |
I missed your comment, but yes that is helpful. To keep the dislike percentage correct it will need some changes to apply the ratio to any new like count that shows up, but that should not be difficult. Still need someone to post a debug log from an affected account. |
In v18.32.xx+, RYD changed from Spanned Text to AnimatedVector (inotia said) |
Unfortunately, or fortunately, the problem fixed itself. I can no longer reproduce this issue. |
It seem to be appeared again |
I have been tracking this issue for three months now, and I will briefly summarize what I have discovered. This is a new format called It was first implemented in source code in YouTube v18.29.38, This issue was also opened at that time. Now that A/B tests are ended and Since the RYD implementation in Nevertheless, I was finally able to implement this in revanced-patches last week. The core commits are as follows: I hope this helps when the Team adds support for new YouTube versions in the near future. |
@LisoUseInAIKyrios Since it is merged into the main branch, you can close the issue |
Type
Cosmetic
Bug description
RYD dislike counter doesnt shows. Probably a A/B testing issue, cuz no toast about cannot connect with api.
Steps to reproduce
Relevant log output
Screenshots or videos
Solution
No response
Additional context
This is probably due to YouTube doing A/B testing. Opening an issue to prepare for future actions, and allowing others to report the same issue here.
Note:
Do NOT reply with "I have the same issue". React with the 👍 emoji instead, unless you have more information to provide. Someone will recieve a email when you comment, including project maintainers. Don't waste their time and allow them tackle with the issue.
Acknowledgements
The text was updated successfully, but these errors were encountered: