Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Youtube "Hide Player flyout menu items" Patch #447

Closed
3 tasks done
Domiiniik opened this issue Aug 16, 2023 · 2 comments
Closed
3 tasks done

bug: Youtube "Hide Player flyout menu items" Patch #447

Domiiniik opened this issue Aug 16, 2023 · 2 comments
Labels
Bug report Something isn't working

Comments

@Domiiniik
Copy link

Type

Error at runtime

Bug description

Player flyout menu items that are selected by user to be hidden are not being hidden in the flyout menu during the video player loading/ buffering phease if you enter it before the video loads, items become hidden in menu once the video itself is loaded otherwise toggled options have No effect when they should the whole time:

Steps to reproduce

Video reference:

Screen_Recording_20230816_225012_YouTube.mp4

Relevant log output

-

Screenshots or videos

No response

Solution

No response

Additional context

You can see that the help item and watch in vr item still being shown until the video is loaded despite me choosing for them to be hidden, they only become hidden when everything is loaded and you reopen the flyout menu again. Intended behaviour should be that No matter when you open the flyout menu, selected items by the user that are suppose to be hidden should remain hidden in the flyout menu No matter when you actually open it.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Domiiniik Domiiniik added the Bug report Something isn't working label Aug 16, 2023
@LisoUseInAIKyrios
Copy link
Contributor

I can reproduce the issue, but oddly the debug logs show the items are not in the litho path/buffer during this brief initial video load (VR item is missing from the logs, yet still shows up as a flyout menu item).

It appears the flyout might be showing a default or initial configuration until the video finishes loading. Not sure how this could be fixed, or even if it's worth fixing because it's only a temporary cosmetic issue.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@LisoUseInAIKyrios
Copy link
Contributor

This seems to be fixed by YT

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants