You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Player flyout menu items that are selected by user to be hidden are not being hidden in the flyout menu during the video player loading/ buffering phease if you enter it before the video loads, items become hidden in menu once the video itself is loaded otherwise toggled options have No effect when they should the whole time:
Steps to reproduce
Video reference:
Screen_Recording_20230816_225012_YouTube.mp4
Relevant log output
-
Screenshots or videos
No response
Solution
No response
Additional context
You can see that the help item and watch in vr item still being shown until the video is loaded despite me choosing for them to be hidden, they only become hidden when everything is loaded and you reopen the flyout menu again. Intended behaviour should be that No matter when you open the flyout menu, selected items by the user that are suppose to be hidden should remain hidden in the flyout menu No matter when you actually open it.
Acknowledgements
I have searched the existing issues and this is a new and no duplicate or related to another open issue.
I have written a short but informative title.
I filled out all of the requested information in this issue properly.
The text was updated successfully, but these errors were encountered:
I can reproduce the issue, but oddly the debug logs show the items are not in the litho path/buffer during this brief initial video load (VR item is missing from the logs, yet still shows up as a flyout menu item).
It appears the flyout might be showing a default or initial configuration until the video finishes loading. Not sure how this could be fixed, or even if it's worth fixing because it's only a temporary cosmetic issue.
oSumAtrIX
transferred this issue from ReVanced/revanced-patches-template
Dec 14, 2023
Type
Error at runtime
Bug description
Player flyout menu items that are selected by user to be hidden are not being hidden in the flyout menu during the video player loading/ buffering phease if you enter it before the video loads, items become hidden in menu once the video itself is loaded otherwise toggled options have No effect when they should the whole time:
Steps to reproduce
Video reference:
Screen_Recording_20230816_225012_YouTube.mp4
Relevant log output
Screenshots or videos
No response
Solution
No response
Additional context
You can see that the help item and watch in vr item still being shown until the video is loaded despite me choosing for them to be hidden, they only become hidden when everything is loaded and you reopen the flyout menu again. Intended behaviour should be that No matter when you open the flyout menu, selected items by the user that are suppose to be hidden should remain hidden in the flyout menu No matter when you actually open it.
Acknowledgements
The text was updated successfully, but these errors were encountered: