Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Swipe controls): Remember Current Brightness At ALL Times #512

Closed
3 tasks done
sliceanddice9 opened this issue Aug 6, 2023 · 4 comments · Fixed by #2996
Closed
3 tasks done

feat(YouTube - Swipe controls): Remember Current Brightness At ALL Times #512

sliceanddice9 opened this issue Aug 6, 2023 · 4 comments · Fixed by #2996
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@sliceanddice9
Copy link

sliceanddice9 commented Aug 6, 2023

Application

YouTube ReVanced Version 18.23.35

Issue

When changing the brightness number for a video, closing the app and then opening the app back up again - the brightness number for any video you watch resets to the default auto value of 0.

Patch

When setting the brightness for videos in landscape/horizontal fullscreen mode via the swipe control brightness gesture, have it stick to whatever brightness number you last configured it to instead of the brightness number defaulting to 0 every time you close the app.

Motivation

YouTube Vanced & YouTube ReVanced Extended via the swipe control brightness gesture, locks the brightness number for all videos you previously set it to even when closing the app followed by opening the app back up. Would love to have that same functionality for YouTube ReVanced as well.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@sliceanddice9 sliceanddice9 added the Feature request Requesting a new feature that's not implemented yet label Aug 6, 2023
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: Remember Current Brightness At ALL Times (Swipe Gesture) feat(YouTube - Swipe controls): Remember Current Brightness At ALL Times Aug 8, 2023
@Fred-Vatin
Copy link

It also needs to remember brightness for any new video played in a playlist. Currently, it is reset when next video starts.

@oSumAtrIX
Copy link
Member

Swipe controls can do that by enabling to remember the brightness value in settings

@sliceanddice9
Copy link
Author

Swipe controls can do that by enabling to remember the brightness value in settings

Wrong. Did you read the OP? The brightness value resets to the default brightness value of 0 AFTER YOU FORCE CLOSE REVANCED AND THEN RE-OPEN REVANCED.

@oSumAtrIX oSumAtrIX reopened this Aug 16, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.59.0](ReVanced/revanced-patches@v2.58.0...v2.59.0) (2022-09-18)

### Features

* **sponsorblock:** string for response error code 400 ([ReVanced#512](ReVanced/revanced-patches#512)) ([d42569f](ReVanced/revanced-patches@818bba7))
@MarcaDian
Copy link
Contributor

MarcaDian commented May 19, 2024

@oSumAtrIX you can close this issue and #1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
4 participants