Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(youtube): auto quality option does not change quality when switching to full screen #589

Closed
3 tasks done
GKid94 opened this issue Jul 17, 2023 · 9 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@GKid94
Copy link

GKid94 commented Jul 17, 2023

Type

Other

Bug description

The auto quality option doesn't work in fullscreen, it won't change the video quality

Steps to reproduce

Play a video and select the auto quality option and go to fullscreen

Relevant log output

/

Screenshots or videos

Screenshot_2023-07-17-10-49-42-306_app revanced android youtube
Screenshot_2023-07-17-10-58-43-830_app revanced android youtube
Screenshot_2023-07-17-11-07-18-242_com miui securitycenter
Screenshot_2023-07-17-11-08-37-553_com android settings

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@GKid94 GKid94 added the Bug report Something isn't working label Jul 17, 2023
@LisoUseInAIKyrios
Copy link
Contributor

Auto quality uses the stock (unpatched) behavior, where the actual video quality is whatever YouTube wants to give you. When changing to full screen, the quality will remain as "auto" and it won't necessarily change anything.

Not a bug

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Auto quality option doesn't work bug(youtube): auto quality option does not change quality when switching to full screen Jul 17, 2023
@GKid94
Copy link
Author

GKid94 commented Jul 17, 2023

@LisoUseInAIKyrios I tried the regular YouTube app and it works there but it doesn't work in Revanced

@LisoUseInAIKyrios
Copy link
Contributor

@GKid94 what do you mean "it works"?

@GKid94
Copy link
Author

GKid94 commented Jul 17, 2023

It changes the resolution to 1080p when I go to fullscreen

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jul 17, 2023

I cannot reproduce with stock YouTube. Resolution does not change when switching to full screen.

If you have the preferred video resolution set to "auto" in ReVanced (under ReVanced -> Misc), then it should never override whatever resolution YouTube chooses.

You can repatch ReVanced and exclude remember-video-quality and exclude old-video-quality-menu. Then video quality will always be 100% same as stock YouTube.

@GKid94
Copy link
Author

GKid94 commented Jul 19, 2023

It happens now on the regular YouTube app

@GKid94
Copy link
Author

GKid94 commented Jul 30, 2023

Still have the problem
Screenshot_2023-07-30-21-38-41-216_app revanced android youtube
Screenshot_2023-07-30-21-42-11-446_com miui securitycenter

@LisoUseInAIKyrios
Copy link
Contributor

It happens now on the regular YouTube app

It's not a ReVanced issue.

@GKid94

This comment was marked as spam.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants