Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Youtube ~ Custom Playback Speed Patch is still using old UI. #63

Closed
3 tasks done
Domiiniik opened this issue Nov 26, 2023 · 2 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@Domiiniik
Copy link

Bug description

Custom Playback Speed Patch is still using old Youtube UI submenu.

Error logs

~

Solution

Apply modern playback speed UI for UI consistency if app version is not spoofed.

Additional context

Comparison: Stock YT (modern UI)
Screenshot_20231126_105952_YouTube
Youtube ReVanced: (playback speed UI is old fullscreen one)
Screenshot_20231126_131427_YouTube

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Domiiniik Domiiniik added the Bug report Something isn't working label Nov 26, 2023
@LisoUseInAIKyrios
Copy link
Contributor

It looks the same to me.

The patch is manually opening the old video speed UI selector, and the UI is using YT code and not ReVanced.

@oSumAtrIX
Copy link
Member

Opening the old menu is the strategy's of the patch to be able to show more speeds

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants