Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: error installing hide-ads on Reddit versions 2023.14.1 and earlier despite target being all versions #653

Closed
3 tasks done
ConnorS1110 opened this issue Jul 2, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@ConnorS1110
Copy link

Type

Error while patching

Bug description

When trying to install hide-apps patch the Reddit app of version 2023.14.1 (last version that allowed sorting by new as default), it fails to install the patch because of an error with a dependency.

Steps to reproduce

Step 1. Try and install the hide-ads patch for reddit version 2023.14.1 or earlier
Step 2. Error when trying to apply hide-ads patch

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Applied disable-screenshot-popup
Failed to apply hide-ads: 'hide-ads' depends on 'hide-comment-ads' but the following error was raised: java.lang.NullPointerException
	at app.revanced.patches.reddit.ad.comments.patch.HideCommentAdsPatch.execute(HideCommentAdsPatch.kt:22)
	at app.revanced.patches.reddit.ad.comments.patch.HideCommentAdsPatch.execute(HideCommentAdsPatch.kt:14)
	at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:333)
	at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:309)
	at app.revanced.patcher.Patcher.access$executePatches$executePatch(Patcher.kt:38)
	at app.revanced.patcher.Patcher$executePatches$1.invokeSuspend(Patcher.kt:358)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:129)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda-20(MainActivity.kt:326)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Rd-IpIH_jmxD15EWmBEFM-jtGsk(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda13.run(Unknown Source:24)
	at java.lang.Thread.run(Thread.java:1012)
Applied sanitize-sharing-links
Repacking patched apk
Compiling resources
Writing modified dex files
Finished!

Screenshots or videos

Screenshot_20230702_030305

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@ConnorS1110 ConnorS1110 added the Bug report Something isn't working label Jul 2, 2023
@oSumAtrIX
Copy link
Member

All should work with the current version and up. Earlier versions can't be guaranteed

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.71.1](ReVanced/revanced-patches@v2.71.0...v2.71.1) (2022-09-28)

### Bug Fixes

* **disable-auto-player-popup-panels:** swap switch toggle state description ([ReVanced#653](ReVanced/revanced-patches#653)) ([f881301](ReVanced/revanced-patches@d2190c0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants