Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug (reddit): Failed to apply sanitize-sharing-links #654

Closed
3 tasks done
TheWitch69 opened this issue Jul 2, 2023 · 2 comments · Fixed by ReVanced/revanced-patches-template#2575 or ReVanced/revanced-patches-template#2553
Labels
Bug report Something isn't working

Comments

@TheWitch69
Copy link

Type

Error while patching

Bug description

Failed to apply sanitize-sharing-links

Steps to reproduce

Use manager 1.3.8

Use Reddit 2023.25.1 & 2023.25.0 with the default patches and fail. 2023.24.0 work.

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Applied disable-screenshot-popup
Applied enable-android-debugging
Applied export-all-activities
Applied hide-ads
Applied predictive-back-gesture
Applied premium-icon-reddit
Applied remove-screen-capture-restriction
Applied remove-screenshot-restriction
Failed to apply sanitize-sharing-links: Failed to resolve ShareLinkFactoryFingerprint
Repacking patched apk
Compiling resources
Writing modified dex files
Finished!

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@TheWitch69 TheWitch69 added the Bug report Something isn't working label Jul 2, 2023
@TheWitch69 TheWitch69 changed the title bug: (youtube-music): Failed to apply sanitize-sharing-links bug: (reddit): Failed to apply sanitize-sharing-links Jul 2, 2023
@TheWitch69 TheWitch69 changed the title bug: (reddit): Failed to apply sanitize-sharing-links bug (reddit): Failed to apply sanitize-sharing-links Jul 2, 2023
@LunaSquee
Copy link

Longer stack trace from revanced builder:

app.revanced.extensions.ExtensionsKt.toErrorResult(Extensions.kt:22) at 
app.revanced.patches.reddit.misc.tracking.url.patch.SanitizeUrlQueryPatch.execute(SanitizeUrlQueryPatch.kt:42) at 
app.revanced.patches.reddit.misc.tracking.url.patch.SanitizeUrlQueryPatch.execute(SanitizeUrlQueryPatch.kt:19) at 
app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:333) at 
app.revanced.patcher.Patcher.access$executePatches$executePatch(Patcher.kt:38) at 
app.revanced.patcher.Patcher$executePatches$1.invokeSuspend(Patcher.kt:358) at 
kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at 
kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:129) at 
app.revanced.utils.patcher.PatcherKt.applyPatchesVerbose(Patcher.kt:84) at 
app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:19) at 
app.revanced.cli.command.MainCommand.run(MainCommand.kt:166) at 
picocli.CommandLine.executeUserObject(CommandLine.java:2026) at 
picocli.CommandLine.access$1500(CommandLine.java:148) at 
picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461) at 
picocli.CommandLine$RunLast.handle(CommandLine.java:2453) at 
picocli.CommandLine$RunLast.handle(CommandLine.java:2415) at 
picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273) at 
picocli.CommandLine$RunLast.execute(CommandLine.java:2417) at 
picocli.CommandLine.execute(CommandLine.java:2170) at app.revanced.cli.main.MainKt.main(Main.kt:7)

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 3, 2023

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.71.2](ReVanced/revanced-patches@v2.71.1...v2.71.2) (2022-09-28)

### Bug Fixes

* **hide-email-address:** invalid instruction offsets ([ReVanced#654](ReVanced/revanced-patches#654)) ([1a3db44](ReVanced/revanced-patches@8656fa2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants