Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reddit sync imgur client id and client secrets key swap #682

Closed
3 tasks done
Rihcus opened this issue Jun 29, 2023 · 7 comments
Closed
3 tasks done

feat: reddit sync imgur client id and client secrets key swap #682

Rihcus opened this issue Jun 29, 2023 · 7 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Rihcus
Copy link

Rihcus commented Jun 29, 2023

Application

Reddit Sync

Issue

Allow uploading to imgur after June 30th and fix current issues with viewing imgur albums in app

Patch

Ability to swap client id and client secret in reddit sync app

Motivation

Preserver imgur functionality in the long run

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Rihcus Rihcus added the Feature request Requesting a new feature that's not implemented yet label Jun 29, 2023
@Rihcus Rihcus changed the title feat: imgur oath key swap feat: reddit sync imgur oath key swap Jun 29, 2023
@Rihcus Rihcus changed the title feat: reddit sync imgur oath key swap feat: reddit sync imgur client id and client secrets key swap Jun 29, 2023
@Doc-4
Copy link

Doc-4 commented Jun 29, 2023

I would also like this to be available, as well as the effective functionality as documented in the attached image to effectively make sync act as if it's the official app, and preserve API access to subreddits marked as NSFW
API

@oSumAtrIX
Copy link
Member

@Rihcus Why should uploading to imgur not work?

@Doc-4 I don't see how changing the secrets grants access to NSFW posts. The authorization method is still OAuth. The official client does not use OAuth as far as I am concerned.

@Rihcus
Copy link
Author

Rihcus commented Jun 29, 2023

@Rihcus Why should uploading to imgur not work?

@Doc-4 I don't see how changing the secrets grants access to NSFW posts. The authorization method is still OAuth. The official client does not use OAuth as far as I am concerned.

I'm not sure if this is the case with reddit sync but in apollo the dev was paying for the imgur api (about $100 a month). I'm not sure the scale reddit sync is working with but I assumed (maybe wrongly) that sync might be paying for a commercial plan to handle the large volume of imgur requests. After June 30th since sync would be discontinued I thought the dev may either delete the key or atleast downgrade it back to free plan at which users would either be faced with rate limits or failure to upload.

Edit:
Apollo was paying approximately $166 a month for imgur api

https://www.pcmag.com/news/developer-says-access-to-reddits-api-would-cost-him-20m-per-year#:~:text=In%20his%20post%2C%20Selig%20also,a%20month%20for%20API%20access.

@Doc-4
Copy link

Doc-4 commented Jun 30, 2023

@Rihcus Why should uploading to imgur not work?

@Doc-4 I don't see how changing the secrets grants access to NSFW posts. The authorization method is still OAuth. The official client does not use OAuth as far as I am concerned.

These are the keys and headers used by the official app, likely a combination effect. Regardless if it's not, any amount of complexity can be figured out by logging network traffic and decompiling the official app, but it seems that's what was done to get this.

@Rihcus
Copy link
Author

Rihcus commented Jul 1, 2023

@Rihcus Why should uploading to imgur not work?
@Doc-4 I don't see how changing the secrets grants access to NSFW posts. The authorization method is still OAuth. The official client does not use OAuth as far as I am concerned.

I'm not sure if this is the case with reddit sync but in apollo the dev was paying for the imgur api (about $100 a month). I'm not sure the scale reddit sync is working with but I assumed (maybe wrongly) that sync might be paying for a commercial plan to handle the large volume of imgur requests. After June 30th since sync would be discontinued I thought the dev may either delete the key or atleast downgrade it back to free plan at which users would either be faced with rate limits or failure to upload.

Edit: Apollo was paying approximately $166 a month for imgur api

https://www.pcmag.com/news/developer-says-access-to-reddits-api-would-cost-him-20m-per-year#:~:text=In%20his%20post%2C%20Selig%20also,a%20month%20for%20API%20access.

So a bit of a snag with this reddit sync (as well as other apps like apollo) use imgur rapid api instead of the stock api since they are commercial apps. Problem with that is if you try swapping out the rapid api key you would need a paid imgur rapid api account at $500 a month (unpractical).

SCR-20230701-ibzf

The end point would need to be changed from:
https://imgur-apiv3.p.rapidapi.com/ to https://api.imgur.com/

image

@Rihcus
Copy link
Author

Rihcus commented Jul 11, 2023

@Rihcus Why should uploading to imgur not work?

@Doc-4 I don't see how changing the secrets grants access to NSFW posts. The authorization method is still OAuth. The official client does not use OAuth as far as I am concerned.

Imgur uploads are officially disabled

screen-20230711-135524.mp4

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.76.2](ReVanced/revanced-patches@v2.76.1...v2.76.2) (2022-09-30)

### Bug Fixes

* **twitter/monochrome-icon:** add missing `File.write` call ([ReVanced#682](ReVanced/revanced-patches#682)) ([de22e3f](ReVanced/revanced-patches@f6a9af0))
@oSumAtrIX
Copy link
Member

I think this is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants