Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Patch Bundle Template with CI #77

Closed
3 tasks done
Ushie opened this issue Nov 21, 2023 · 9 comments
Closed
3 tasks done

feat: Patch Bundle Template with CI #77

Ushie opened this issue Nov 21, 2023 · 9 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Ushie
Copy link
Member

Ushie commented Nov 21, 2023

Feature description

Create a Patch Bundle template repository, with necessary CI for releases with support for this ReVanced/revanced-manager#572 format

Motivation

With the upcoming release of ReVanced Manager v2, it's about time to prepare Patch Bundles as a concept, currently Patch Bundles need to fork this repository and (optionally) remove existing patches

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Ushie Ushie added the Feature request Requesting a new feature that's not implemented yet label Nov 21, 2023
@oSumAtrIX
Copy link
Member

If we create a template repository, how do we keep changes in sync?

@Ushie
Copy link
Member Author

Ushie commented Nov 21, 2023

A template repository gives you the base to start, but it isn't your base if that makes sense, maintainers can keep things as is or they must manually keep up with changes

However, I've found this action https://github.com/AndreasAugustin/actions-template-sync

@Ushie
Copy link
Member Author

Ushie commented Nov 21, 2023

But that action won't help you migrate your own changes, there's no way around maintainers having to keep up with updates themselves

@oSumAtrIX
Copy link
Member

What I mean is, say we bump ReVanced Patcher, now we would commit to the template repo as well as our patches repository.

@Ushie
Copy link
Member Author

Ushie commented Nov 21, 2023

That's intended, it's possible to have something like the sync action that I mentioned above but that action won't automatically migrate the patches if something about the patch structure changes, ReVanced Patcher bumps may come with necessary changes to patches

@oSumAtrIX
Copy link
Member

This is an annoying burden. Alternatively, a project template could be comited here. This way we'd be able to update the template at the same time

@Ushie
Copy link
Member Author

Ushie commented Nov 21, 2023

How would you commit a template here?

@oSumAtrIX
Copy link
Member

On second thought, this is too complex to realize, a template repository is easier.

@oSumAtrIX
Copy link
Member

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants