Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Twitch patching fails with Recommended Version (17.1.0) #79

Closed
2 of 3 tasks
MRMIdAS opened this issue Nov 20, 2023 · 3 comments
Closed
2 of 3 tasks

bug: Twitch patching fails with Recommended Version (17.1.0) #79

MRMIdAS opened this issue Nov 20, 2023 · 3 comments
Labels
Bug report Something isn't working

Comments

@MRMIdAS
Copy link

MRMIdAS commented Nov 20, 2023 •
edited by oSumAtrIX
Loading

Bug description

Attempting to patch Twitch with the new patches. Patching fails with LOTS of errors, Assuming it's a version mismatch despite using recommended version.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@MRMIdAS MRMIdAS added the Bug report Something isn't working label Nov 20, 2023
@LisoUseInAIKyrios
Copy link
Contributor

16.9.1 is the recommended version, use that.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented Nov 21, 2023 •
edited
Loading

16.9.1 is the recommended version, use that.

The manager currently suggests 17.1.0 because only the settings patch is constrained to 16.9.1 while all other Twitch patches support 17.1.0

All patches work on 16.9.1. Should I PR to add 16.9.1 as a supported version for all the patches?

SmartSelect_20231120_223907_Chrome.jpg

@oSumAtrIX
Copy link
Member

Yes, that version works for all patches

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MRMIdAS @oSumAtrIX @KobeW50 @LisoUseInAIKyrios