feat(patch): fix YouTube bug: Quitting the app after opening Autoplay settings resets some General settings.

[pressRtowin]

Application

YouTube

Issue

Note: this is not a bug report as the issue exists on stock YouTube. This is a feature request to patch the undesired behavior (if possible)

See title. Zoom to fill screen does not seem to be affected but both Double-tap to seek and Enable stats for nerds are. I have not tested other settings.

To reproduce:

1. Open ReVanced.
2. Change affected settings in General.
3. Resume normal operation of YouTube.
4. At any point during normal operation, open the Autoplay tab in settings.
5. Fully close YouTube.
6. Open YouTube.
7. Check General settings and see that some settings have been reset.

Patch

Fix the above behavior. All settings should be persistent regardless of menus opened.

Motivation

It fixes a very annoying issue with YouTube.

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[oSumAtrIX]

If this is an issue with YouTube, it's their responsibility to fix it

[pressRtowin]

There's no point in debating whose responsibility it is to fix the issue. Obviously Google should fix bugs in their own app, but considering how much time Google can take to get around to fixing simple issues, isn't it worth a look in the code to see if there is a quick fix that could be implemented in the meantime?

Isn't the whole spirit of ReVanced making a better user experience for YouTube users in ways Google hasn't yet or won't do? This seems to fall squarely in that.

[oSumAtrIX]

No, we don't have access to the code, YouTube does. It is not a "quick fix" for us because we would need to make the efforts to reverse engineer the app, figure out the source of the issue and develop a patch that fixes it unlike Google simply pushing the fix as they should because it's an issue on their end. We are not YouTube tech support. The patch request is unreasonable.

[pressRtowin]

At no point did I imply there was a guaranteed quick fix. My words were:

isn't it worth a look in the code to see if there is a quick fix that could be implemented in the meantime?

Regardless, my point is to keep the possibility of a patch on the table in the case that Google doesn't resolve the issue themselves in the meantime (quite common with Google), and in the case that someone could come along, see this issue, and decide they want to tackle it, rather than outright dismissing it.

[oSumAtrIX]

Looking at the code/Reversing it already implies that the fix is not quick, the sentence is contradicting therefore.

[pressRtowin]

Does it matter if the fix is not quick? If you yourself don't want to take the time to implement it, fine. But why bury this in the ground and pretend it's not an issue? There is also the possibility of creative workarounds that might effectively resolve the issue without necessarily fixing the underlying bug, but shutting down the discussion entirely kills any chance of someone seeing this and thinking of something like that.

I don't understand your insistence to single-handedly determine what someone else who contributes to this project works on. What's wrong with leaving the issue on the table and closing it if the unlikely event of Google fixing it themselves does happen?

[oSumAtrIX]

This issue remains a patch request which is our decision to dismiss. The request is unreasonable as previously explained.