Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect singleVersionForAllModules for added modules #179

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

mkavanagh
Copy link
Contributor

Modules with no previous artifact were not being written into the changes file, so they were not being kept up to date even when singleVersionForAllModules was enabled.

This caused project versions to get out of sync if a new module was added to the project at the same time as any API changes were made to other modules.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #179 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
- Coverage     73.48%   73.47%   -0.02%     
  Complexity      149      149              
============================================
  Files           175      175              
  Lines          8992     8992              
  Branches       1501     1501              
============================================
- Hits           6608     6607       -1     
+ Misses         1803     1802       -1     
- Partials        581      583       +2     
Impacted Files Coverage Δ Complexity Δ
...org/revapi/maven/AbstractVersionModifyingMojo.java 75.64% <100.00%> (+0.51%) 0.00 <0.00> (ø)
...org/revapi/java/JavaElementDifferenceAnalyzer.java 79.92% <0.00%> (-0.71%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c65173...33b7b4d. Read the comment docs.

@metlos
Copy link
Member

metlos commented Apr 28, 2020

Nice one! Thanks for also adding the integration test!

@metlos metlos merged commit e31ba7d into revapi:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants