New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Documentation - Threading.scad - Inconsistent description for default value of slop #81

Closed

fe60 opened this issue Mar 23, 2021 · 1 comment

Assignees

Labels

bug

Contributor

fe60 commented Mar 23, 2021 •

edited

Loading

Describe the bug
The documentation describes the default value of slop in two different ways.

Default: PRINTER_SLOP
default=0.2

Version 2 is used for the following modules:
https://github.com/revarbat/BOSL/wiki/threading.scad#threaded_nut
https://github.com/revarbat/BOSL/wiki/threading.scad#buttress_threaded_rod
https://github.com/revarbat/BOSL/wiki/threading.scad#buttress_threaded_nut
https://github.com/revarbat/BOSL/wiki/threading.scad#acme_threaded_nut
https://github.com/revarbat/BOSL/wiki/threading.scad#square_threaded_nut

Expected behavior
The default value should be mentioned in a consistent way. I prefer version 1 referring to the global variable.

The text was updated successfully, but these errors were encountered:

fe60 added the bug label

fe60 assigned revarbat

Contributor Author

fe60 commented May 2, 2021

Fixed in fork of wiki https://github.com/fe60/bosl-wiki/commit/c1518e140cb780945f9f120c8c3d547ef4ea1db0

fe60 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment