Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager: Spend: Number of sigs invalid #205

Closed
darosior opened this issue Aug 15, 2021 · 1 comment
Closed

Manager: Spend: Number of sigs invalid #205

darosior opened this issue Aug 15, 2021 · 1 comment
Assignees
@edouardparis
Labels
bug Something isn't working
Milestone
Third demo: huffl...

Comments

@darosior
Copy link
Member

It should count the number of valid signatures, not the number of signatures in the PSBT
@darosior darosior added the bug Something isn't working label Aug 15, 2021
@edouardparis edouardparis added this to the sprint 6 milestone Sep 21, 2021
@darosior
Copy link
Member Author

darosior commented Nov 1, 2021

We hit this again in today's demo..

edouardparis added a commit to edouardparis/revault-gui that referenced this issue Nov 7, 2021
@edouardparis
Filter spend transaction bip32 derivation
3f5b7c4 
Because of the use of revault_tx v0.4
bip32_derivations are already in psbt.

In order to use dummysigner or hw storing
multiple keys, Derivations are filtered
in order to keep only derivations with
targeted xpubs fingerprints.

close revault#205
@edouardparis edouardparis mentioned this issue Nov 7, 2021
Merged
edouardparis added a commit to edouardparis/revault-gui that referenced this issue Nov 8, 2021
@edouardparis
Filter spend transaction bip32 derivation
98e4008 
Because of the use of revault_tx v0.4
bip32_derivations are already in psbt.

In order to use dummysigner or hw storing
multiple keys, Derivations are filtered
in order to keep only derivations with
targeted xpubs fingerprints.

close revault#205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edouardparis edouardparis

Labels
bug Something isn't working
Projects
None yet
Milestone
Third demo: huffle puffer
Development

No branches or pull requests
2 participants
@edouardparis @darosior