Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dummysigner: add low level exit handling #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dummysigner: add low level exit handling #295

wants to merge 1 commit into from

Conversation

edouardparis
Copy link
Member

  • do not rely on iced close_on_exit
  • listen to window event and ctrl-c signal to exit
  • drop any connection on exit

close #278

@edouardparis
dummysigner: add low level exit handling
5769708 
- do not rely on iced close_on_exit
- listen to window event and ctrl-c signal to exit
- drop any connection on exit

close revault#278
@darosior
Copy link
Member

Still have the issue that i can't close when a connection is active
image
image

@darosior
Copy link
Member

@danielabrozzoni: i take this review :)

@darosior darosior removed the request for review from danielabrozzoni December 16, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darosior darosior Awaiting requested review from darosior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dummysigner freezes if you close it before quitting the GUI's signing screen
2 participants
@edouardparis @darosior