Make cosigning servers optional #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2021
darosior
commented
Oct 26, 2021
Comment on lines
-532
to
+533
| .is_some() => | ||
| .any(|sub| matches!(sub, SemanticPolicy::Older(..))) => | ||
| { | ||
| // Now, the mans are either a Threshold or directly pks (in the case the | ||
| // thresh is an 'and()', pks are flattened in the upper 'and()'). | ||
| if let Some(thresh) = subs.iter().find_map(|sub| match sub { | ||
| return subs.iter().find_map(|sub| match sub { |
There was a problem hiding this comment.
This didn't belong in this commit.
darosior
added a commit
to revault/revaultd
that referenced
this pull request
Oct 27, 2021
5c116f7 qa: sanity check a deployment with no cosig (Antoine Poinsot) 9fb7d2a tests: make Cosigning Servers optional in the test framework (Antoine Poinsot) d382d46 rpc: make cosig poll optional in 'setspendtx' (Antoine Poinsot) dab90c1 doc: small fixups to the spending process docs (Antoine Poinsot) 3bb2f81 config: make the 'cosigners' field optional (Antoine Poinsot) Pull request description: Although Cosigning Server aren't necessary to a Revault deployment, `revaultd` has deliberately been assuming they were always present for simplicity. This fixes it by: - allowing managers to not specify any Cosigning Server in their config - polling them at spending time only if they were specified This is based on #278 and #282 and needs revault/revault_tx#112 ACKs for top commit: danielabrozzoni: ACK 5c116f7 - tests pass in local, I didn't test mscompiler but I guess it's used by pytest anyways. All cases seem handled when git grepping `cosigs`/`cosigners` darosior: > ACK [5c116f7](5c116f7) - tests pass in local, I didn't test mscompiler but I guess it's used by pytest anyways. All cases seem handled when git grepping cosigs/cosigners Tree-SHA512: 0a34c4ca812c969fbb2e02cb79e843504837745772442ace531959407237bc8f2521b706bcc9be5622c7d3044c4faf4bb861a16edc6743c734e4135f6ed1db8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.