Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ou refactor #426

Merged
merged 14 commits into from
Apr 16, 2024
Merged

Ou refactor #426

merged 14 commits into from
Apr 16, 2024

Conversation

kopperud
Copy link
Contributor

proposal to change the PhyloOrnsteinUhlenbeckREML class such that it better corresponds with the FitzJohn (2012; Methods Ecol Evol) supplement

notable changes

  • Change the name/suffix from REML to Pruning. Reason being, I think it's not the REML likelihood, and so calling it REML is misleading at best. The likelihoods computed using this pruning algorithm are identical to the likelihoods computed using the generalized-least-squares (or vcv) method, as long as the root treatment is the same (i.e. root state = theta). If it really were a REML likelihood, then the likelihoods would not be the same
  • Remove storing of the normalizing factors, since they were set to 1.0 and were not used anyway
  • Compute the log-normalizing factor for the node, instead of the normalizing factor, saving some calls to exp(...)
  • Rename "contrasts" (which they were not) to "means"
  • Rename "contrast_uncertantity" to "variances"
  • Add some comments to explain where the equations come from

question: what to do about the related classes, for example the state-dependent OU process (which is on a different branch)?

@kopperud kopperud marked this pull request as draft January 30, 2024 14:13
@kopperud kopperud requested a review from hoehna January 30, 2024 14:13
@kopperud kopperud marked this pull request as ready for review January 30, 2024 14:14
Copy link
Member

@hoehna hoehna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to keep PhyloOrnsteinUhlenbeckREML as an alias for backwards compatibility.

Copy link
Member

@hoehna hoehna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good.

@bjoelle bjoelle merged commit ca7c5de into development Apr 16, 2024
20 checks passed
@bjoelle bjoelle deleted the ou-refactor branch April 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants