-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ou refactor #426
Merged
Merged
Ou refactor #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoehna
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to keep PhyloOrnsteinUhlenbeckREML
as an alias for backwards compatibility.
src/revlanguage/distributions/phylogenetics/branchrate/Dist_PhyloOrnsteinUhlenbeckPruning.cpp
Show resolved
Hide resolved
hoehna
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal to change the
PhyloOrnsteinUhlenbeckREML
class such that it better corresponds with the FitzJohn (2012; Methods Ecol Evol) supplementnotable changes
REML
toPruning
. Reason being, I think it's not the REML likelihood, and so calling it REML is misleading at best. The likelihoods computed using this pruning algorithm are identical to the likelihoods computed using the generalized-least-squares (or vcv) method, as long as the root treatment is the same (i.e. root state = theta). If it really were a REML likelihood, then the likelihoods would not be the sameexp(...)
question: what to do about the related classes, for example the state-dependent OU process (which is on a different branch)?