Fix the uniform topology prior #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bredelings
approved these changes
Apr 8, 2024
davidcerny
force-pushed
the
fix-topology-prior
branch
from
097d752
to
4a709c7
Compare
davidcerny
force-pushed
the
fix-topology-prior
branch
from
aeb7ebd
to
065c246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an ancient yet easy-to-fix issue, namely the incorrect probabilities yielded by the uniform topology distributions (#212). This error shouldn't affect inference (the ranking of trees should stay exactly the same), but it's nice to make sure we are getting the math right. Both the issue and the solution to it were identified by @plewis, and the new test is adapted from the example script provided in his bug report.