Don't flatten arrays of stochastic variables in checkpoint files #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also affect logging multidimensional arrays to CSV files? I think @mlandis was looking at this, but it might be a separate issue... |
|
If you happen to have a test case, I'd be happy to try it out! |
bjoelle
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another trivial, single-line bug fix that we've never gotten around to implementing, this time for issue #339. @jsigao suggested this as a solution and implemented it on his branch; I verified that it's sufficient to get rid of the issue. While the plan was to make it just one part of a more extensive checkpointing fix, it's been more than a year, and it seems worth fixing the issue even without a more general solution to MPI and MC^3 checkpointing problems. However, precisely because the problem of getting checkpointing to work under MPI is still unresolved, I'm holding off from adding a full-blown checkpointing test.