Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revel run cmd become more robust #56

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Revel run cmd become more robust #56

merged 1 commit into from
Jun 24, 2016

Conversation

jeevatkm
Copy link
Contributor

As proposed in revel/revel#389 also run much improved with following-

  • First thing revel run can detect import path from current directory
  • revel run brings following combination
    • revel run import-path run-mode port
    • revel run import-path run-mode
    • revel run import-path port
    • revel run run-mode port
    • revel run import-path
    • revel run run-mode
    • revel run port
    • revel run

Whichever is not supplied will default to already know values of Revel.

@jeevatkm jeevatkm added this to the v0.14 milestone Jun 18, 2016
@jeevatkm jeevatkm self-assigned this Jun 18, 2016
@brendensoares
Copy link
Member

So revel run [import-path] [run-mode] [port]

This is going to add a nice convenience factor to the Revel dev workflow! 💃

@@ -31,41 +32,92 @@ You can set a port as an optional third parameter. For example:
revel run github.com/revel/samples/chat prod 8080`,
}

// RunArgs is hold revel run parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"is hold" to "holds"

@brendensoares
Copy link
Member

👍 Looks good!

@jeevatkm jeevatkm merged commit 28c0df2 into develop Jun 24, 2016
@brendensoares brendensoares deleted the revel-run-cmd-robust branch April 24, 2017 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants