Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Docs Patch #43

Merged
merged 106 commits into from Jan 7, 2015
Merged

Major Docs Patch #43

merged 106 commits into from Jan 7, 2015

Conversation

pedromorgan
Copy link
Member

Am baby sitting my aunt.. so using time to make revel docs better..

here's first patch, but going thru and tweaking bits and pieces..

I kind want to push to the "upstream" origin and have perms, but am nervous to do so.. (maybe into a new "docs_next" branch)

@pedromorgan pedromorgan changed the title 2014 end of year holiday Major Docs Patch Dec 31, 2014
title: Parameters
url: binding.html
title: Request Parameters
url: paramaters.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: change "paramaters" to "parameters"

- `revel run` - will start `dev` mode as the default
- `revel run prod` - will start with `prod` mode.

Revel creates new apps with **dev** and **prod** run modes defined, but the user may
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps more specifically "the developer may" instead of "user"?

request flow. This may take the form of recurring tasks that update cached data
or one-off tasks for sending emails.
Revel provides the **jobs** framework for performing work asynchronously, outside of the
request flow. This may take the form of [recurring tasks](#RecurringJobs) that updates cached data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"updates" should be "update"

@pedromorgan
Copy link
Member Author

So afaik, bar a few teaks, this is ready to merge...
would prefer to tweak a reasonably live site from now on really..

@brendensoares
Copy link
Member

Are you not going to remove the manual <a name="..."> tags in favor of using the already present heading id's?

@pedromorgan
Copy link
Member Author

Re title: Currently its this
https://github.com/pedromorgan/revel.github.io/blob/pedro/_includes/head.html#L5
Which makes eg

 Controllers | Revel - A Web Application Framework for Go

Whats I really like is: title | section | Revel A web...... eg

 Controllers | Manual | Revel - A Web Application Framework for Go

Also this way we can also version.. eg

    Controllers | Manual | v1.23 | Revel - A Web Application Framework for Go

This will avoid confusion if we have duplicate names, eg controllers in manual + godoc

I haven't figured out how to do that et, but need a "template set command" or alike

However, the title on the home page needs to be more unique as u suggested, and I haven't figured figured how to do that yet.

@pedromorgan
Copy link
Member Author

re named anchors...

I've got mixed feeling about using the id tag, namelly different languages.. This is a problem I had with smarty manual from yonder year.. with having to redeclare the link, as the "title" changed... anyway.. that thought is in the back of my head..

I've left a couple in, such as linking to "appconf.html#jobs", as the title is "Scheduled Jobs", and we might wanna change that maybe...but "jobs" dont work alone (in fact might "Jobs" and "Cron"

So some of the anchors I left in, and maybe used, but I will nuke them if I find any that offend... and dont think this is that big a deal, there are very few and kinda intentional atmo.. for now if that ok..

If thats whats stopping a "merge".. .then i need time.. and more focused on creating and testing content, eg debugging than removing anchors that work..

brendensoares added a commit that referenced this pull request Jan 7, 2015
@brendensoares brendensoares merged commit cfc93c0 into revel:develop Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants