Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditional recursive call #1542

Closed
chavacava opened this issue Oct 15, 2021 · 0 comments
Closed

Unconditional recursive call #1542

chavacava opened this issue Oct 15, 2021 · 0 comments
Assignees
@notzippy
Labels
resolved

Comments

@chavacava
Copy link

revel/logger/handlers.go

Lines 52 to 54 in ee237a4

func CallerFuncHandler(h LogHandler) LogHandler {
return CallerFuncHandler(h)
}

The function CallerFuncHandler calls itself unconditionally (i.e. infinite loop)

(Found by revive's rule unconditional-recursion)
@notzippy notzippy self-assigned this Mar 5, 2022
@notzippy notzippy mentioned this issue Mar 5, 2022
Merged
lujiacn pushed a commit to lujiacn/revel that referenced this issue Mar 9, 2022
@notzippy @lujiacn
Fixed log recursive call
de88ff9 
There was a recusive loop in the logger, this fixes it
closes revel#1542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notzippy notzippy

Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notzippy @chavacava