Params Time Binding

[ready4god2513]

I may have been doing something wrong, but I believe that there is a mistake in the docs. The docs state that The SQL standard time formats [“2006-01-02”, “2006-01-02 15:04”] are built in. but that doesn't appear to be the case.

Right here is where the bindings are set- https://github.com/revel/revel/blob/master/binder.go#L226 which is perfect. HOWEVER, the default config to ship with revel actually does have the date format set here- https://github.com/revel/revel/blob/master/skeleton/conf/app.conf.template#L69 So by default revel appears to only bind on 01/02/2006 and 01/02/2006 15:04

So either the docs need to change or the default config needs to change.

Let me know if I am incorrect on this. Thanks!

[ghost]

Hi, @ready4god2513. You are right, looks like the docs are outdated.

The SQL standard time formats [“2006-01-02”, “2006-01-02 15:04”] are built in.

These formats were built in ages ago:

Now they are not.

Fix is more than welcome here: https://github.com/revel/revel.github.io/tree/develop

Related docs links

https://revel.github.io/manual/appconf.html#formatting
https://revel.github.io/manual/binding.html#date--time

[ghost]

We are probably coming back to the time format mentioned in the docs: #872 (comment). So, changes to the docs may not be needed.

[ptman]

So change config to ISO8601 ? I can do a PR if that moves this forward.

[jeevatkm]

As per my understanding, binder code look okay. Just skeleton app.conf needs an update from

format.date     = 01/02/2006
format.datetime = 01/02/2006 15:04

to

format.date     = 2006-01-02
format.datetime = 2006-01-02 15:04

@ptman would you like to do it?

[jeevatkm]

Taken care, thanks to @ptman

I'm closing this one.