Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev new and rev run panic when being called without arguments #12

Merged
merged 2 commits into from Sep 12, 2012
Merged

rev new and rev run panic when being called without arguments #12

merged 2 commits into from Sep 12, 2012

Conversation

jstemmer
Copy link
Contributor

I've added some checks to the args slices to prevent an index out of range error.

The `rev new` and `rev run` commands would crash if the user tried to
run them without any arguments.
@jstemmer
Copy link
Contributor Author

I've added printing the help for both commands. Wasn't sure if I should prepend the help messages with a tilde or not. IMO the entire output would look cleaner without them :)

Maybe in the future the run command could detect a revel app in the current dir and run it without having to type the entire package path.

@robfig
Copy link
Contributor

robfig commented Sep 12, 2012

Yea, I agree with that. Thanks.

robfig added a commit that referenced this pull request Sep 12, 2012
rev new and rev run panic when being called without arguments
@robfig robfig merged commit b421c92 into revel:master Sep 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants