Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies at build time #694

Closed
wants to merge 1 commit into from
Closed

Install dependencies at build time #694

wants to merge 1 commit into from

Conversation

pushrax
Copy link
Contributor

@pushrax pushrax commented Aug 21, 2014

Final fix for #290

@pushrax pushrax added this to the v0.11 milestone Aug 21, 2014
@pushrax
Copy link
Contributor Author

pushrax commented Aug 21, 2014

Works for Go 1.3+ only, should we increase the minimum Go version for Revel?

@brendensoares
Copy link
Member

@pushrax that's a good question. Here's a dumb question in return: Where do we declare a minimum Go version for Revel?

As a temporary fix, could we include the -i flag dynamically based on the current version of Go?

@ghost
Copy link

ghost commented Aug 26, 2014

@brendensoares, as I know .travis.yml is the only place where Golang version is defined. There is a special // +build constraint in Golang, but Revel doesn't use it.

@brendensoares
Copy link
Member

@AnonX // +build "go1.3"?

@brendensoares
Copy link
Member

@robfig @pushrax it seems -i may not be the solution per the latest developments on #290

@pushrax
Copy link
Contributor Author

pushrax commented Aug 30, 2014

Closing this for now since it needs further investigation.

@pushrax pushrax closed this Aug 30, 2014
@brendensoares brendensoares deleted the install-deps branch April 24, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants