Fix for static module files #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the prefix from fixed parameters was overriding the absPath and causing 404 on static files for modules (e.g. testrunner)
|
Thank you, @nadeemc. We've discussed this issue (which is, I must admit, my fault) with @notzippy in #809 and waiting for response of either @brendensoares or @pushrax. They should decide whether one more patch release is possible or the fix should be merged without release or we shouldn't merge it to master at all. |
ghost
added this to the 
|
@AnonX no reason we can't do another patch as long as it's not a breaking change. That's the point of patch versioning :) |
brendensoares
added a commit
that referenced
this pull request
Jan 4, 2015
Fix for static module files #809
brendensoares
added a commit
to revel/modules
that referenced
this pull request
Jan 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the prefix from fixed parameters was overriding the absPath and
causing 404 on static files for modules (e.g. testrunner)