Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InitServer function returning the http handler #879

Merged
merged 2 commits into from Jan 23, 2016
Merged

Add InitServer function returning the http handler #879

merged 2 commits into from Jan 23, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2015

This is a minimalist approach to somewhat solve #648, #553 and #549. It is minimally invasive and just moves around some code.

I'm looking for feedback on how this could be improved or generally if that's an approach worthy of merging :-)

An example of how this can be integrated into an app lives here: https://github.com/metafex/revel-modules/tree/master/server. Personally I'm running this in production now and don't have any problems with it yet.

The example server module depends on revel/cmd#22 to generate the necessary code in the main function.

@brendensoares
Copy link
Member

@metafex I'm very curious to look at this in more detail! I'll try to reply tomorrow after work, but first, sleep. :)

@brendensoares brendensoares self-assigned this Mar 2, 2015
@brendensoares brendensoares added this to the v0.13 milestone Mar 22, 2015
brendensoares added a commit that referenced this pull request Jan 23, 2016
Add InitServer function returning the http handler
@brendensoares brendensoares merged commit ed77e38 into revel:develop Jan 23, 2016
@brendensoares
Copy link
Member

👍 great PR

@ghost ghost deleted the feature/expose-http-handler branch May 28, 2016 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants