Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12 Release #903

Merged
merged 74 commits into from
Mar 25, 2015
Merged

v0.12 Release #903

merged 74 commits into from
Mar 25, 2015

Conversation

brendensoares
Copy link
Member

No description provided.

dmitrykakunin and others added 30 commits September 17, 2014 15:19
Add a Put and Patch method to the TestSuite class for testing http PUT
and PATCH requests.
Add testing support for HTTP PUT & PATCH
Removes Revel's mailer code in favor of other Go packages
Moves modules to dedicated repo and updates import paths
Moves harness code to 'revel/cmd' repo and updates Travis CI paths
New import paths for Go sub-respositories
Conflicts:
	harness/build.go
brendensoares and others added 19 commits February 23, 2015 22:23
Only shows debug stack details in DevMode
Fixes wildcard reverse routing logic and adds test
Add default http.Status code for render methods.
Fixes router app start bug without routes.
Some http clients will react unfavoriably to compression when there
must not be any response body.
Use "302 Found" HTTP code for redirect
ensure routes are loaded before returning from OnAppStart callback
Optimize search of template names
@ghost
Copy link

ghost commented Mar 22, 2015

@brendensoares Don't forget to include in release notes info on how to upgrade to v0.12. Looks like testing package is the only breaking change. So, users will have to update import paths of TestSuite type in files of tests directory.

  • Old version:
package tests

import "github.com/revel/revel"

type AppTest struct {
    revel.TestSuite
}
  • Required change:
package tests

import "github.com/revel/revel/testing"

type AppTest struct {
    testing.TestSuite
}

Apart from that everything works for my not-so-small application as expected, nothing is broken, its tests are passed.


And we also need to update README && not include https://github.com/revel/revel/blob/develop/.travis.yml#L8 to master.

@brendensoares
Copy link
Member Author

@AnonX I noted the new import path. Also updated the README.md and switched the TravisCI branch to master.

We need to figure out a clean way to switch the Travis branch during release. For now, we'll just have to switch it back to develop after the release. Any better ideas?

brendensoares added a commit that referenced this pull request Mar 25, 2015
@brendensoares brendensoares merged commit 67891f9 into master Mar 25, 2015
@ghost
Copy link

ghost commented Mar 25, 2015

@brendensoares We didn't update version.go: https://github.com/revel/revel/blob/master/version.go#L5

I'll let you know when I come up with a better idea.

@brendensoares
Copy link
Member Author

@AnonX Should it be 0.12.0 or 0.12.0rc or what?

@notzippy
Copy link
Collaborator

@brendensoares I would go with all numeric 0.12.0

@ghost
Copy link

ghost commented Mar 25, 2015

@brendensoares I thought v0.12.0dev meant it was develop branch. Well, if it didn't and dev part is intentional meaning revel is not stable then it's OK (although, I think v0 means exactly that without any suffixes). But what BUILD_DATE means? https://github.com/revel/revel/blob/master/version.go#L7 Why is it Jan 19, 2015?

@brendensoares
Copy link
Member Author

@AnonX I agree that v0 means we've yet to reach the desired foundational features.

@notzippy I'm good with plain 0.12.0, but we may want to discuss a release candidate workflow to make releases more often as @pedromorgan has recently asked.

@brendensoares
Copy link
Member Author

@AnonX BUILD_DATE refers to date of release in my mind. Thoughts? I've updated both date and version number now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet