Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate commands on repo's readme #380

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

majjikishore007
Copy link
Contributor

Description

In this update, I have eliminated redundant command lines in the setup script, specifically the duplicate cp .env.example .env commands. This change simplifies the initial setup process and reduces potential confusion for new contributors.

Type of change

  • [-] Bug fix (non-breaking change which fixes an issue)

Changes

before:

# Get the code
git clone --depth 1 https://github.com/revertinc/revert

# Copy the example env file
cp .env.example .env
cp .env.example .env
cp packages/backend/.env.example packages/backend/.env
cp packages/client/.env.example packages/client/.env
cp packages/js/.env.example packages/js/.env
cp packages/react/.env.example packages/react/.env
cp packages/vue/.env.example packages/vue/.env

# Update these .env files with your own secrets if you'd like to.

# Then In the root directory run

# When running for the first time to seed the database. (RUN ONLY ONCE)
docker-compose run db-seed

# For subsequent runs
docker-compose up -d

after:

# Get the code
git clone --depth 1 https://github.com/revertinc/revert

# Copy the example env file
cp .env.example .env
cp packages/backend/.env.example packages/backend/.env
cp packages/client/.env.example packages/client/.env
cp packages/js/.env.example packages/js/.env
cp packages/react/.env.example packages/react/.env
cp packages/vue/.env.example packages/vue/.env

# Update these .env files with your own secrets if you'd like to.

# Then In the root directory run

# When running for the first time to seed the database. (RUN ONLY ONCE)
docker-compose run db-seed

# For subsequent runs
docker-compose up -d

Copy link

vercel bot commented Nov 28, 2023

@majjikishore007 is attempting to deploy a commit to the Revertdev Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Nov 28, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@jatinsandilya jatinsandilya changed the title remove duplicate commands chore: remove duplicate commands on repo's readme Nov 30, 2023
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks for your contributioin @majjikishore007!

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 9:26am

@jatinsandilya jatinsandilya merged commit b2333b2 into revertinc:main Nov 30, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants