This repository has been archived by the owner on Jun 6, 2020. It is now read-only.
Add pan events #25
Merged
Add pan events #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds probably failing due to missing symbols (relies on changes in esy-sdl2#6) |
bryphe
reviewed
Nov 21, 2019
src/sdl2_wrapper.cpp
Outdated
| @@ -401,6 +401,8 @@ CAMLprim value Val_SDL_Event(SDL_Event *event) { | |||
|
|
|||
| int tag, mouseButton; | |||
|
|
|||
| printf("event type is %d while pan event type is %d and mousewheel is %d\n", event->type, SDL_PANEVENT, SDL_MOUSEWHEEL); | |||
There was a problem hiding this comment.
We should remove the printfs for the final version
Et7f3
reviewed
Nov 23, 2019
Change to pushing errors to stderr as suggested by @Et7f3 Co-Authored-By: Et7f3 <cadeaudeelie@gmail.com>
Et7f3
approved these changes
Nov 26, 2019
…o add_pan_events
|
I think if you bring in the latest master, this should be build now @szbergeron 👍 |
bryphe
reviewed
Dec 6, 2019
src/sdl2_wrapper.cpp
Outdated
| @@ -551,6 +567,7 @@ CAMLprim value Val_SDL_Event(SDL_Event *event) { | |||
| v = Val_SDL_WindowEvent(23, event->window.windowID); | |||
| break; | |||
| default: | |||
| fprintf(stderr, "Unknown event in sdl2_wrapper, event enum code was %d\n", event->type); | |||
There was a problem hiding this comment.
We should remove this as well - might cause issues in the case where we run on Windows w/o a console allocated (we could hook into the SDL_Log mechanism though instead)
bryphe
suggested changes
Dec 6, 2019
|
Looks great, @szbergeron ! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: plumbs support for smooth scrolling
Adds a new "MousePan" event type that matches up with revery-ui/esy-sdl2#6
Needs to be integrated with Revery proper before it will work