Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency): esy-skia -> 91c98f6 #1033

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

glennsl
Copy link
Member

@glennsl glennsl commented Dec 29, 2020

This brings in a fix to esy-skia that allows it to build with clang 10.2 on Arch Linux.

For some possibly unrelated reason I'm not able to build revery directly due to a failure building ocamlfind, and despite being able to build Oni2 with this same fix, but I'm submitting this now anyway to see what the CI says.

@glennsl
Copy link
Member Author

glennsl commented Dec 29, 2020

Ok, looks like there's an issue with OCaml 4.10.2 on my machine, and that Oni2 builds fine because it's pinned to 4.10.0 while the constraint on revery is ~4.10, which then picked 4.10.2 when I touched other dependencies.

I'll continue to investigate this separately and see no reason for that to block this from being merged.

@bryphe
Copy link
Member

bryphe commented Dec 30, 2020

This brings in a fix to esy-skia that allows it to build with clang 10.2 on Arch Linux.

Nice, thanks @glennsl !

Ok, looks like there's an issue with OCaml 4.10.2 on my machine, and that Oni2 builds fine because it's pinned to 4.10.0 while the constraint on revery is ~4.10, which then picked 4.10.2 when I touched other dependencies.

I believe this is due to this bug: esy/esy#1171 (it was the reason I pinned Onivim to 4.10.0)

esy@0.6.7 may fix this, as it includes a fix for that particular issue - I haven't tested it yet though.

@bryphe
Copy link
Member

bryphe commented Dec 30, 2020

Testing esy@0.6.7 here: #1035

@glennsl
Copy link
Member Author

glennsl commented Dec 30, 2020

I believe this is due to this bug: esy/esy#1171 (it was the reason I pinned Onivim to 4.10.0)

Ah, yeah that seems likely.

esy@0.6.7 may fix this, as it includes a fix for that particular issue

I was already using 0.6.7. @esy-nightly/esy fixed it though, but now esy-harfbuzz fails to build...

error: command failed: './esy/prep.sh' (exited with 127)

None of this affects this PR though, so I'll merge it.

@glennsl glennsl merged commit 14402ad into revery-ui:master Dec 30, 2020
@glennsl glennsl deleted the fix/depdednency/esy-skia/91c98f6 branch December 30, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants