Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border rendering in transparent views #147

Merged
merged 2 commits into from Dec 24, 2018
Merged

Conversation

OhadRau
Copy link
Collaborator

@OhadRau OhadRau commented Dec 22, 2018

Quick fix for #145 -- couldn't get it to compile locally so this isn't tested yet. After pulling from upstream I keep getting the following error:

File "src/Core/Window.re", line 307, characters 30-52:                                                                                                                                              
Error: Unbound value Glfw.glfwDestroyWindow             

Tried to reinstall reason-glfw but I think this might be because of changes to the development version that haven't been pushed to NPM.

@OhadRau
Copy link
Collaborator Author

OhadRau commented Dec 24, 2018

Update: Figured out how to get rid of that error (had to delete the _esy dir and reinstall). Tested this and it's working with fully transparent views:
image

@bryphe
Copy link
Member

bryphe commented Dec 24, 2018

Works great! Thanks @OhadRau for the fix!

@bryphe bryphe merged commit cca02e3 into revery-ui:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants