Bugfix: Exception on start #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinsho
pushed a commit
to akinsho/revery
that referenced
this pull request
Jan 20, 2019
* Fix regression - crash on start when mouse moves * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Intermittently when starting the example app, get an error like:
Defect: This is a regression from #216 . We calculate certain properties (
transform,worldTransform,bbox, etc) during rendering. Prior to the first render - these properties are not available. However, if there is mouse movement, the mouse event can potentially get dispatched prior to the render. The mouse dispatching uses the calculated bbox to figure out if it needs to dispatch an event. In this case - there is a crash occurring because the bounding box hasn't been calculated yet.Fix: Don't dispatch events until these calculated properties are available.