Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refer correct input to get golangci-lint version detail #170

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

ashwinspg
Copy link
Member

Issue

In the Actions Metadata file, input: golangci_lint_version is the data that the action used for determining the version of golangci-lint from the client. Instead of using input: golangci_lint_version in the codebase, golangci_version is used to fetch the version. This cause the action to use the latest version irrespective of the input from the client.

@ashwinspg ashwinspg changed the title Fix: Refer correct input to get golangci-lint version details Fix: Refer correct input to get golangci-lint version detail Nov 9, 2021
@shogo82148 shogo82148 merged commit c9d2bba into reviewdog:master Nov 9, 2021
@review-dog
Copy link
Member

Hi, @ashwinspg! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

@ashwinspg
Copy link
Member Author

Hi, @ashwinspg! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

@shogo82148 Thank you 👍 for merging my changes.

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

I am glad to receive the invitation to be part of reviewdog community.
I am looking forward to making more contributions :)

@ashwinspg ashwinspg deleted the fix-golangci_lint_version branch November 9, 2021 12:28
@ashwinspg
Copy link
Member Author

Publish a tag (v2.0.2) for this change. I need to use tag in my project rather than referring a commit ref.

@review-dog @shogo82148 @haya14busa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants