Skip global offenses to avoid "undefined method `begin'" #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohbarye
force-pushed
the
skip-global-offense
branch
from
8560e81
to
c609128
Compare
ohbarye
changed the title
|
@mgrachev Could you review this when you have time? |
mgrachev
approved these changes
Nov 18, 2021
|
@ohbarye 👋 Thanks a lot for your help 🔥 |
|
🚀 [bumpr] Bumped! New version:v2.0.2 Changes:v2.0.1...v2.0.2 |
|
Thanks for your quick review too 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #55
Change
As described #55 (comment), rdjson_formatter fails to build diagnostic when a given offense has
NO_LOCATION.NO_LOCATIONindicates a global offense that has no particular location. For example, an empty file is applicable. Since no correction can be applied to global offenses, it should skip reporting (that's howaction-rubodop@v1works).https://github.com/rubocop/rubocop/blob/de4f7cdd266999bf2cfbe78bd7fd8a0d4580863d/lib/rubocop/cop/base.rb#L105-L112