Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewdog_flags & workdir input #13

Merged
merged 6 commits into from
May 8, 2020
Merged

Add reviewdog_flags & workdir input #13

merged 6 commits into from
May 8, 2020

Conversation

haya14busa
Copy link
Member

No description provided.

@haya14busa haya14busa added the bump:minor bump minor version automatically after merging the pull request label May 8, 2020
-name="linter-name (misspell)" \
-reporter="${INPUT_REPORTER:-github-pr-check}" \
-level="${INPUT_LEVEL}" \
${INPUT_REVIEWDOG_FLAGS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

@@ -1,3 +1,5 @@
Determinisitic result is important.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (misspell)] reported by reviewdog 🐶
"Determinisitic" is a misspelling of "Deterministic"

@@ -1,3 +1,5 @@
Determinisitic result is important.

colour # <= Check -locale
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (misspell)] reported by reviewdog 🐶
"colour" is a misspelling of "color"

@@ -1,3 +1,5 @@
Determinisitic result is important.

colour # <= Check -locale

langauge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (misspell)] reported by reviewdog 🐶
"langauge" is a misspelling of "language"

@@ -0,0 +1,2 @@
Determinisitic result is important!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (misspell)] reported by reviewdog 🐶
"Determinisitic" is a misspelling of "Deterministic"

@haya14busa haya14busa changed the title Add reviewdog_flags input Add reviewdog_flags & workdir input May 8, 2020
@haya14busa haya14busa merged commit 2ee535f into master May 8, 2020
@haya14busa haya14busa deleted the reviewdog_flags branch May 8, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor bump minor version automatically after merging the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant