Fix Banner Removal and tfsec Severity Mapping #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo82148
added
the
bump:minor
shogo82148
approved these changes
Oct 20, 2023
|
Hi, @ysano! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
|
🚀 [bumpr] Bumped! New version:v1.20.0 Changes:v1.19.0...v1.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two specific issues to improve the existing functionality:
Banner Removal: Initially, the workaround implemented for removing the banner was not functioning as expected. We've made adjustments to properly discard the banner from STDERR.
Severity Mapping for tfsec: Previously, CRITICAL issues identified by tfsec were being passed to reviewdog as null. This issue has been corrected.
These fixes enhance the tool's usability and reliability for Github Actions etc.