Skip to content

Commit

Permalink
fix condition
Browse files Browse the repository at this point in the history
  • Loading branch information
haya14busa committed Jul 25, 2020
1 parent 434c329 commit 201045c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion service/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ func buildSingleSuggestion(c *reviewdog.Comment, s *rdf.Suggestion) (string, err
return "", fmt.Errorf("the Diagnostic's lines and Suggestion lines must be the same. %d-%d v.s. %d-%d",
drange.GetStart().GetLine(), drange.GetEnd().GetLine(), start.GetLine(), end.GetLine())
}
if start.GetColumn() > 1 || end.GetColumn() > 1 {
if start.GetColumn() > 0 || end.GetColumn() > 0 {
// TODO(haya14busa): Support non-line based suggestion.
return "", errors.New("non line based suggestions (contains column) are not supported yet")
}
Expand Down

0 comments on commit 201045c

Please sign in to comment.