Skip to content

Commit

Permalink
Merge pull request #315 from reviewdog/fix-circleci
Browse files Browse the repository at this point in the history
circleci: do not use || true for golint
  • Loading branch information
haya14busa committed Sep 21, 2019
2 parents e0ea865 + 010a353 commit 22b611d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .circleci/config.yml
Expand Up @@ -12,7 +12,10 @@ jobs:
command: 'echo "Golang $(go version)"'
- run: 'curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $(go env GOPATH)/bin'
- run: '( cd linters && go get golang.org/x/lint/golint )'
- run: 'golint ./... || true | reviewdog -f=golint -name=golint-circleci -reporter=github-pr-review'
- run:
command: |-
set +o pipefail
golint ./... | reviewdog -f=golint -name=golint-circleci -reporter=github-pr-review
test:
working_directory: ~/reviewdog
docker:
Expand Down

0 comments on commit 22b611d

Please sign in to comment.