Add integration tests for handling unexpected failures

# ------------------------ >8 ------------------------ # reviewdog results
reviewdog · May 31, 2020 · 3e79cf2 · 3e79cf2
1 parent 9565536
commit 3e79cf2
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
@@ -129,6 +129,26 @@ jobs:
           cd ./_testdata/ && golint ./... | reviewdog -f=golint -name=golint-pr-review-nofilter -reporter=github-pr-review -filter-mode=nofilter -fail-on-error || EXIT_CODE=$?
           test "${EXIT_CODE}" = 1
 
+      - name: Unexpected failure (github-pr-review)
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          cd ./_testdata/ && reviewdog -conf=reviewdog_error.yml \
+            -reporter=github-pr-review || EXIT_CODE=$?
+          test "${EXIT_CODE}" = 1
+      - name: Unexpected failure (github-check)
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          cd ./_testdata/ && reviewdog -conf=reviewdog_error.yml \
+            -reporter=github-check || EXIT_CODE=$?
+          test "${EXIT_CODE}" = 1
+      - name: Unexpected failure (local)
+        run: |
+          cd ./_testdata/ && reviewdog -conf=reviewdog_error.yml \
+            -reporter=local -diff='git diff master' || EXIT_CODE=$?
+          test "${EXIT_CODE}" = 1
+
   golangci-lint:
     if: github.event_name == 'pull_request'
     name: runner / golangci-lint

diff --git a/_testdata/reviewdog_error.yml b/_testdata/reviewdog_error.yml
@@ -0,0 +1,10 @@
+runner:
+  # OK
+  golint-ok:
+    cmd: golint ./...
+    format: golint
+    level: warning
+  test-fail:
+    cmd: 'echo "test failure"; exit 1'
+    errorformat:
+      - "%f:%l:%c:%m"