github-check: Output end line in annotation title.

reviewdog · Jul 22, 2020 · cf9b48c · cf9b48c
1 parent 6f8f74a
commit cf9b48c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/doghouse/server/doghouse.go b/doghouse/server/doghouse.go
@@ -252,8 +252,16 @@ func (ch *Checker) toCheckRunAnnotation(c *reviewdog.FilteredCheck) *github.Chec
 			a.EndColumn = github.Int(int(e))
 		}
 	}
-	if ch.req.Name != "" {
-		a.Title = github.String(fmt.Sprintf("[%s] %s#L%d", ch.req.Name, loc.GetPath(), loc.GetRange().GetStart().GetLine()))
+	toolName := c.Diagnostic.GetSource().GetName()
+	if toolName == "" {
+		toolName = ch.req.Name
+	}
+	if toolName != "" {
+		line := fmt.Sprintf("L%d", startLine)
+		if startLine < endLine {
+			line += fmt.Sprintf("-L%d", endLine)
+		}
+		a.Title = github.String(fmt.Sprintf("[%s] %s#%s", toolName, loc.GetPath(), line))
 	}
 	if s := strings.Join(c.Lines, "\n"); s != "" {
 		a.RawDetails = github.String(s)

diff --git a/doghouse/server/doghouse_test.go b/doghouse/server/doghouse_test.go
@@ -191,15 +191,15 @@ func TestCheck_OK(t *testing.T) {
 					EndLine:         github.Int(3),
 					AnnotationLevel: github.String("warning"),
 					Message:         github.String("test multiline"),
-					Title:           github.String("[haya14busa-linter] sample.new.txt#L2"),
+					Title:           github.String("[haya14busa-linter] sample.new.txt#L2-L3"),
 				},
 				{
 					Path:            github.String("sample.new.txt"),
 					StartLine:       github.Int(2),
 					EndLine:         github.Int(3),
 					AnnotationLevel: github.String("warning"),
 					Message:         github.String("test multiline with column"),
-					Title:           github.String("[haya14busa-linter] sample.new.txt#L2"),
+					Title:           github.String("[haya14busa-linter] sample.new.txt#L2-L3"),
 				},
 				{
 					Path:            github.String("sample.new.txt"),