Skip to content

Commit

Permalink
Merge pull request #701 from reviewdog/remove-ci-flag
Browse files Browse the repository at this point in the history
remove deprecated -ci flag
  • Loading branch information
haya14busa committed Jul 26, 2020
2 parents ab6aed1 + 853ad65 commit d427679
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions cmd/reviewdog/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ type option struct {
fDiffStrip int
list bool // list supported errorformat name
name string // tool name which is used in comment
ci string
conf string
runners string
reporter string
Expand Down Expand Up @@ -182,7 +181,6 @@ func init() {
flag.IntVar(&opt.fDiffStrip, "f.diff.strip", 1, fDiffStripDoc)
flag.BoolVar(&opt.list, "list", false, listDoc)
flag.StringVar(&opt.name, "name", "", nameDoc)
flag.StringVar(&opt.ci, "ci", "", ciDoc)
flag.StringVar(&opt.conf, "conf", "", confDoc)
flag.StringVar(&opt.runners, "runners", "", runnersDoc)
flag.StringVar(&opt.reporter, "reporter", "local", reporterDoc)
Expand Down Expand Up @@ -223,12 +221,6 @@ func run(r io.Reader, w io.Writer, opt *option) error {
return runList(w)
}

// TODO(haya14busa): clean up when removing -ci flag from next release.
if opt.ci != "" {
return errors.New(`-ci flag is deprecated.
See -reporter flag for migration and set -reporter="github-pr-review" or -reporter="github-pr-check" or -reporter="gitlab-mr-commit"`)
}

if opt.tee {
r = io.TeeReader(r, w)
}
Expand Down

0 comments on commit d427679

Please sign in to comment.