Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run reviewdog using project based config #47

Closed
haya14busa opened this issue Dec 3, 2016 · 1 comment
Closed

run reviewdog using project based config #47

haya14busa opened this issue Dec 3, 2016 · 1 comment
Projects

Comments

@haya14busa
Copy link
Member

Use reviewdog.yml in the root project to run reviewdog might be useful.

For now, we have to add -ci or -diff arg in accordance with the situation, so we cannot run lint easily both in local and CI server.

By using reviewdog conf file, we can run reviewdog $ reviewdog [-diff="git diff master"] or $ reviewdog -ci=droneio. It's really easy to run and easy to integrate with editor or commit hook.

Security

In CI server, reviewdog needs secret GitHub API token and attackers can create pull-request to get secret token if CI service is not secure.
Drone.io handles this problem with checksum of yml file, but if we introduce reviewdog conf file, checksum of drone.yml doesn't protect the secret token.

To handle this problem, reviewdog can store secret token in memory, remove secret env var, and run linter commands

@haya14busa
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
reviewdog
In Progress
Development

No branches or pull requests

1 participant