ProjectConf: dogfooding #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haya14busa
force-pushed
the
project-run5-dogfooding
branch
from
0c683b3
to
f85cb56
Compare
haya14busa
force-pushed
the
project-run5-dogfooding
branch
from
f85cb56
to
8551eb2
Compare
Current coverage is 79.71% (diff: 100%)@@ master #54 diff @@
==========================================
Files 10 10
Lines 710 710
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 566 566
Misses 100 100
Partials 44 44
|
review-dog
reviewed
Dec 12, 2016
| @@ -10,6 +10,8 @@ import ( | |||
| "testing" | |||
| ) | |||
|
|
|||
| var _ = fmt.Sprintf("", 1, 2, 3) | |||
There was a problem hiding this comment.
[govet] reported by reviewdog 🐶
no formatting directive in Sprintf call
review-dog
reviewed
Dec 12, 2016
| @@ -120,6 +120,10 @@ func (w *Reviewdog) Run(r io.Reader) error { | |||
| return nil | |||
| } | |||
|
|
|||
| var unused = "" | |||
|
|
|||
| var NoComment = "" | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported var NoComment should have comment or be unexported
review-dog
reviewed
Dec 12, 2016
| @@ -120,6 +120,10 @@ func (w *Reviewdog) Run(r io.Reader) error { | |||
| return nil | |||
| } | |||
|
|
|||
| var unused = "" | |||
|
|
|||
| var NoComment = "" | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported var NoComment should have comment or be unexported
This reverts commit c72964f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #47